Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add support for PyQt6 #5884

Merged
merged 34 commits into from
Jun 3, 2022
Merged

[ENH] Add support for PyQt6 #5884

merged 34 commits into from
Jun 3, 2022

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Mar 10, 2022

Issue

Add support for PyQt6

Requires merge and release of

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec marked this pull request as draft March 10, 2022 11:36
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #5884 (85b83db) into master (70452b2) will increase coverage by 0.15%.
The diff coverage is 95.69%.

@@            Coverage Diff             @@
##           master    #5884      +/-   ##
==========================================
+ Coverage   86.34%   86.50%   +0.15%     
==========================================
  Files         315      315              
  Lines       67079    67259     +180     
==========================================
+ Hits        57922    58182     +260     
+ Misses       9157     9077      -80     

@markotoplak
Copy link
Member

@ales-erjavec, both dependencies are now released. Could you please update this PR?

@ales-erjavec ales-erjavec force-pushed the pyqt6 branch 3 times, most recently from 1e5c313 to 7a73696 Compare April 29, 2022 11:25
@ales-erjavec ales-erjavec marked this pull request as ready for review April 29, 2022 11:50
@markotoplak markotoplak merged commit 8c1787f into biolab:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants