[ENH] Datasets: Add language selection #6358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6358 +/- ##
=======================================
Coverage 87.39% 87.40%
=======================================
Files 317 317
Lines 68238 68289 +51
=======================================
+ Hits 59640 59688 +48
- Misses 8598 8601 +3 |
janezd
force-pushed
the
datasets-language
branch
from
b77bd36 to
4d32ec6
Compare
|
Please also change the icon that shows that the data set is local but not loaded. Currently, there is a filled grey circle to denote this, but the difference with the filled green circle is not substantial [for instance, to the people with a degree of color blindness]. It will help if the grey circles are empty. |
This will be another PR because it requires changing (and then releasing) orange-widget-base. |
janezd
force-pushed
the
datasets-language
branch
from
4d32ec6 to
46803f8
Compare
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Data sets in the repository now have a language flag, and Data Sets widget allows user to filter files by language.
Default is English, but translations of Orange to other languages can change this default.
Description of changes
Includes