Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Feature as Predictor #6852

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jul 13, 2024

Issue

Closes #6813.

Description of changes

A widget that "predicts" classes from a single column. I have several questions.

  • The widget offers
    • discrete columns whose values are the same, or a subset of, class values,
    • and numeric columns if the class is binary.
  • When using numeric columns, its values are used as probabilities of class with index 1 (in which case they must be between 0 and 1) or mapped through logistic function with user-specified offset and coefficient.
  • Widget also outputs a model, so it can be fed into Test Learner and compared with other models.

I've put the widget into category Evaluate. This is not a model but rather a trick to turn a Table into Evaluation Results, hence it belongs there because any user interested in this transformation would look for a widget in this category.

Ideas from the discussion:

  • Replace radios with a check box to apply log reg. The check box is disabled and checked when the column contains values outside 0 - 1.
  • Remove line edits and always compute logistic regression
  • Support numeric outcomes; offer fitting with linear regression
Includes
  • Code changes
  • Tests
  • Documentation

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 98.90110% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.29%. Comparing base (70ebf27) to head (62d47f2).
Report is 153 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6852      +/-   ##
==========================================
+ Coverage   88.27%   88.29%   +0.02%     
==========================================
  Files         326      328       +2     
  Lines       71137    71319     +182     
==========================================
+ Hits        62793    62972     +179     
- Misses       8344     8347       +3     

@janezd janezd changed the title Add Classify by Column Add "Column as Model" Jul 14, 2024
@janezd janezd force-pushed the classify-by-column branch 2 times, most recently from e6c0c49 to 62d47f2 Compare July 16, 2024 20:24
@janezd janezd added the needs discussion Core developers need to discuss the issue label Nov 28, 2024
@janezd janezd removed the needs discussion Core developers need to discuss the issue label Nov 30, 2024
@markotoplak markotoplak changed the title Add "Column as Model" [ENH] Feature as Predictor Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to create 'Evaluation Result' directly from 'Table' data?
1 participant