Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] iso8601 is a required field #84

Open
Erikpostt opened this issue Sep 10, 2024 · 1 comment
Open

[BUG] iso8601 is a required field #84

Erikpostt opened this issue Sep 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Erikpostt
Copy link
Contributor

I don't quite remember why we made the iso_8601 fields obligatory when storing metadata, but perhaps we want to reconsider this as it is not always relevant (perhaps only for longitudinal studies).

Describe the Bug
For the publication of the first paper on arm swing, we are using a different dataset which does not have any dates/times attached to it. I would like to store it as tsdf though.

To Reproduce
Steps to reproduce the behavior:

  1. Create a metadata variable without the start_iso8601 and end_iso8601 fields
  2. Append the metadata to the list of metafiles: l_metafiles.append(tsdf.write_binary_file(path_output, f"values.bin", data_sensors, metadata_sensor))

image

Expected Behavior
The metadata is stored without an iso8601 field.

Actual Behavior
TSDFMetadataFieldError: Value for the obligatory TSDF field 'start_iso8601' is missing in the provided TSDF metadata file.

tsdf Version

  • 0.5.2

Environment Details

  • OS: Windows
  • Python Version: 3.11.5
@Erikpostt Erikpostt added the bug Something isn't working label Sep 10, 2024
@kretep
Copy link
Member

kretep commented Sep 11, 2024

The _iso8601 fields are obligatory as specified in the TSDF format specification (see https://arxiv.org/abs/2211.11294). So in order to keep the library in-line with the format, I don't think we'll change this. You could perhaps consider using a dummy date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants