Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 the format functionality of biome lsp-proxy doesn't recognize biome.json #402

Closed
1 task done
nissy-dev opened this issue Sep 24, 2023 · 8 comments
Closed
1 task done
Labels
A-LSP Area: language server protocol S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@nissy-dev
Copy link
Contributor

nissy-dev commented Sep 24, 2023

Environment information

No

What happened?

In discord server, some users faced the issue that Intellij plugin doesn't resolve biome.json.
I also confirmed that lsp-proxy command does not resolve the config file. (But, start command seems to resolve it.)

similar issue: xiaoxin-sky/lapce-rome#1

Expected result

biome lsp-proxy should recognize biome.json like biome start.
Or, intellij plugin should use biome start instaad of biome lsp-proxy?

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@nissy-dev nissy-dev added A-LSP Area: language server protocol S-Help-wanted Status: you're familiar with the code base and want to help the project labels Sep 24, 2023
@victor-teles
Copy link
Contributor

@nissy-dev I think biome format also doesn't resolve biome.json in the plugin.

On my end the biome lsp-proxy resolves the biome.json correctly

Biome.Intellij.mp4

@xulongwu4
Copy link

I am using the biome CLI and I can confirm that lsp-proxy does not recognize the biome.json file in the path I specified through --config-path.

@nissy-dev
Copy link
Contributor Author

nissy-dev commented Sep 26, 2023

@victor-teles

I think biome format also doesn't resolve biome.json in the plugin.
On my end the biome lsp-proxy resolves the biome.json correctly

I'm in the same situation. Thanks for confirming correctly!

Considering about the other comments and the situation withbiome start, It still seems there is possible that biome lsp-proxy is something wrong.

@xulongwu4
Copy link

To be precise, I verified that the formatting functionality of the biome lsp does not respect the biome.json file passed by the --config-path key. I haven't tried the lint functionality, so it is possible that the biome.json file is loaded correctly, but the formatting function of lsp does not respect that config file.

@nissy-dev nissy-dev changed the title 🐛 biome lsp-proxy doesn't recognize biome.json 🐛 the format functionality of biome lsp-proxy does doesn't recognize biome.json Sep 26, 2023
@nissy-dev nissy-dev changed the title 🐛 the format functionality of biome lsp-proxy does doesn't recognize biome.json 🐛 the format functionality of biome lsp-proxy doesn't recognize biome.json Sep 27, 2023
@thelinuxlich
Copy link

This is happening with me on VSCode extension, are there any workarounds?

@ematipico
Copy link
Member

@thelinuxlich I suggest you open a new issue with the required information to triage your issue. Your problem might be caused by something different.

@thelinuxlich
Copy link

@ematipico I just discovered what's the issue, if I have a workspace with many folders, biome-lsp doesn't find the biome.json relative to the current project. If the project is the workspace, it works. But it's a bug, right?

@ematipico
Copy link
Member

@thelinuxlich there's an issue already open: biomejs/biome-vscode#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LSP Area: language server protocol S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

No branches or pull requests

5 participants