Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: don't exit with an error for max limit files #4375

Open
Tracked by #3727
ematipico opened this issue Oct 24, 2024 · 2 comments
Open
Tracked by #3727

BREAKING: don't exit with an error for max limit files #4375

ematipico opened this issue Oct 24, 2024 · 2 comments
Assignees
Milestone

Comments

@ematipico
Copy link
Member

No description provided.

@ematipico ematipico self-assigned this Oct 24, 2024
@ematipico ematipico added this to the Biome 2.0 milestone Oct 24, 2024
@ematipico ematipico changed the title BREAKING: don't emit diagnostic for unknown file BREAKING: don't emit diagnostic for max limit files Oct 24, 2024
@Conaclos
Copy link
Member

@ematipico Could you motivate this change?

@ematipico
Copy link
Member Author

ematipico commented Oct 24, 2024

It was pointed out to me that this diagnostic is emitted as an error to the user, while it's an expected behaviour inside the library. Biome by default doesn't handle the size of a certain limit, and since it's the default, it should ignore those files.

Now, the user that pointed out was a jerk and ignored them, however, that is true.

So I plan to change the logic, emit a diagnostic with a different severity, but still make the CLI working. It should not exit with an error code.

UPDATE: I updated the title of the issue

@ematipico ematipico changed the title BREAKING: don't emit diagnostic for max limit files BREAKING: don' exit with an error for max limit files Oct 24, 2024
@ematipico ematipico changed the title BREAKING: don' exit with an error for max limit files BREAKING: don't exit with an error for max limit files Oct 24, 2024
@ematipico ematipico linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants