-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grit): complete formatting of all nodes #4520
Conversation
6d95f3a
to
143520d
Compare
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
CodSpeed Performance ReportMerging #4520 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice!
Maybe you can do a small announcement on it as well when you merge ;)
I would make sure it's available in the playground before making an announcement so people can try it out. |
I still need to understand why it currently fails 🤔 weird |
Not yet, there are still things missing :) |
Summary
This PR completes the formatting of grit, using straightforward logic. We will improve the formatting as we go, and as we identify possible code that could be improved
Comments aren't appropriately handled yet in the sense that we don't have specific logic about their placement in certain conditions.
I also renamed the node
GritCurlyPredicateList
toGritPredicateCurly
. The node wasn't a list, and I renamed it following the internal convention.Test Plan
I updated the snapshots. I couldn't find the code for the newly formatted nodes.