Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 [useNamingConvention] Ignore declarations inside an external TypeScript module #4545

Open
1 task done
cr7pt0gr4ph7 opened this issue Nov 15, 2024 · 0 comments
Open
1 task done
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@cr7pt0gr4ph7
Copy link
Contributor

cr7pt0gr4ph7 commented Nov 15, 2024

Rule name

lint/style/useNamingConvention

Description

The documentation says that "declarations inside an external TypeScript module" should be ignored by useNamingConvention (as described at the bottom of the relevant docs section), but the implementation actually complains about them.

Example:

declare module "myExternalModule" {
  export interface my_INTERFACE {}
}

Expected Result

No Errors are reported

Actual Result

Lint is generated for my_INTERFACE.

Playground link

https://biomejs.dev/playground/?lintRules=all&code=ZABlAGMAbABhAHIAZQAgAG0AbwBkAHUAbABlACAAIgBtAHkARQB4AHQAZQByAG4AYQBsAE0AbwBkAHUAbABlACIAIAB7AAoAIAAgAGUAeABwAG8AcgB0ACAAaQBuAHQAZQByAGYAYQBjAGUAIABtAHkAXwBJAE4AVABFAFIARgBBAEMARQAgAHsAfQAKAH0ACgA%3D

Environment information

https://github.com/biomejs/biome/actions/runs/11854065273/job/33035446404?pr=4542

Tangentially related issues:

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@cr7pt0gr4ph7 cr7pt0gr4ph7 added the S-Needs triage Status: this issue needs to be triaged label Nov 15, 2024
@Conaclos Conaclos added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug and removed S-Needs triage Status: this issue needs to be triaged labels Nov 15, 2024
cr7pt0gr4ph7 added a commit to cr7pt0gr4ph7/biome that referenced this issue Nov 15, 2024
cr7pt0gr4ph7 added a commit to cr7pt0gr4ph7/biome that referenced this issue Nov 15, 2024
cr7pt0gr4ph7 added a commit to cr7pt0gr4ph7/biome that referenced this issue Nov 15, 2024
cr7pt0gr4ph7 added a commit to cr7pt0gr4ph7/biome that referenced this issue Nov 15, 2024
cr7pt0gr4ph7 added a commit to cr7pt0gr4ph7/biome that referenced this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

No branches or pull requests

2 participants