Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow trailing commas on biome.jsonc #4551

Closed
wants to merge 1 commit into from

Conversation

yukulele
Copy link

@yukulele yukulele commented Nov 16, 2024

Summary

vscode reports trailing commas as error in biome.jsonc

Test Plan

try to use this file on vscode:

// biome.jsonc
{
  "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
  "json": {
    "formatter": {
      "trailingCommas": "all",
    },
  },
}

adding "allowTrailingCommas": true to configuration_schema.json fix it

@yukulele yukulele changed the title allow trailing commas on biome.jsonc fix: allow trailing commas on biome.jsonc Nov 16, 2024
@ematipico
Copy link
Member

This file is auto-generated, we need to change the source code that generates it.

@ematipico
Copy link
Member

Closing, JSON schema doesn't have a allowTrailingCommas keyword

@ematipico ematipico closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants