-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(biome_glob): add dedicated crate for globs #4609
Conversation
81e938c
to
799cd3f
Compare
CodSpeed Performance ReportMerging #4609 will degrade performances by 7.57%Comparing Summary
Benchmarks breakdown
|
799cd3f
to
72c0a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Conaclos! Looking forward to use this crate in other places :)
I left some feedback around docs. Overall, we follow this pattern:
- Explain feature
- Explain example
- Show code example
Just a small nit-pick: On a (only partially) related note:
|
The idea is to get rid of Pattern. See #4611 for the whole plan, help is very welcome |
03e4540
to
aa10598
Compare
aa10598
to
d2d69a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Conaclos !
5f57c0b
to
7a64284
Compare
Summary
Move
RetsrictedGlob
frombiome_js_analyze
to a dedicated crate.This allows us to use
RetsrictedGlob
outsidebiome_js_analyze
.Also, I renamed
RetsrictedGlob
intoGlob
. Possible alternative names areGlobPattern
andPattern
.I added some documentation for the crate and put optional dependencies behind feature flags.
Test Plan
CI must pass.