fix(noUselessFragments): fix result has invalid syntax when under JSX attribute #4648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes: #4553
I add judge logic for the fix case like:
When the fragment child is a
JSXElement
like<span>Loading...</span>
here, in the fix process, we will keep the JSXAttributeValue.So it will fix as:
The attribute
fallback
's value is aJsxExpressionAttributeValue
not aJsxTagExpression
.Test Plan
I add test case.