Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch js-api openProject() #5000

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Conversation

ianzone
Copy link
Contributor

@ianzone ianzone commented Jan 31, 2025

Summary

definition openProject(): void; is redundant and will emit type error when passing the path param, so it's removed. Also, the jsDoc is added to openProject(path).

Test Plan

remove the wrong definition and add jsDoc to openProject()
@github-actions github-actions bot added the A-Changelog Area: changelog label Jan 31, 2025
@ematipico
Copy link
Member

Thank you. Can you please rebase your branch and add a changelog? The contribution guide in the next branch has been updated

@ianzone
Copy link
Contributor Author

ianzone commented Feb 8, 2025

Thank you. Can you please rebase your branch and add a changelog? The contribution guide in the next branch has been updated

command not found
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants