Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chech chr #24

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Chech chr #24

merged 2 commits into from
Jun 27, 2024

Conversation

biona001
Copy link
Owner

Resolves #23, and also added a check to make sure the VCF file's position is sorted within chromosomes.

@biona001 biona001 self-assigned this Jun 27, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 8.39%. Comparing base (a4054ca) to head (56cde83).
Report is 4 commits behind head on main.

Files Patch % Lines
src/make_hdf5.jl 0.00% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #24      +/-   ##
========================================
- Coverage   8.43%   8.39%   -0.05%     
========================================
  Files          6       6              
  Lines        948     953       +5     
========================================
  Hits          80      80              
- Misses       868     873       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biona001 biona001 merged commit cbb753a into main Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly check CHROM field is Int
2 participants