addec CUDA.jl support for czt #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 92.92% 93.01% +0.08%
==========================================
Files 18 18
Lines 1018 1031 +13
==========================================
+ Hits 946 959 +13
Misses 72 72 ☔ View full report in Codecov by Sentry. |
roflmaostc
reviewed
Jul 15, 2024
src/czt.jl
Outdated
Comment on lines
86
to
90
| aw :: AbstractArray{CT, D} | ||
| fft_fv :: AbstractArray{CT, D} | ||
| wd :: AbstractArray{CT, D} | ||
| fftw_plan! :: AbstractFFTs.Plan | ||
| ifftw_plan! :: AbstractFFTs.ScaledPlan |
There was a problem hiding this comment.
Those types are not concretely typed:
Better do:
struct Lol{AA1}
aw::AA1
fft_fv::AA1
``
There was a problem hiding this comment.
I see and then put the contraints in the where clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a comparison for the CuArray results and the Array results was made by hand for an example.
No further dependencies were added.
However, an internal function ("FourierTools.get_kernel_1d") changed its signature.