Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure pageview hit sent before event hit in Google analytics tracking #214

Open
newgene opened this issue Apr 2, 2022 · 0 comments
Open
Labels

Comments

@newgene
Copy link
Member

newgene commented Apr 2, 2022

See this warning from Google Analytics:

image

Relevant code here:

for i in range(0, len(events), 20):
yield HTTPRequest(
'http://www.google-analytics.com/batch', method='POST',
body='\n'.join(events[i: i+20])
)

Since we now send hits in batch with async, we should make sure event and pageview hits send together if they belong to the same pageview.

@newgene newgene added the bug label Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant