Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManualDumper needs a 'path' input #60

Open
erikyao opened this issue Mar 24, 2021 · 1 comment
Open

ManualDumper needs a 'path' input #60

erikyao opened this issue Mar 24, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@erikyao
Copy link

erikyao commented Mar 24, 2021

The dump method of ManualDumper requires a path argument (see dumper.py#L934).

Therefore there must be a text field for this input argument on the web UI for every ManualDumper. E.g. cadd source in myvariant.info:

cadd
@erikyao erikyao added the bug Something isn't working label Mar 24, 2021
@erikyao
Copy link
Author

erikyao commented Apr 22, 2021

Otherwise we can specify the path (or sub-folder) in the ManualDumper as a class attribute (to be overwritten by child dumper classes) and hence get the absolute path automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikyao