Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps downloadFile() does not need begin hook #19

Open
birdofpreyru opened this issue Nov 8, 2023 · 0 comments
Open

Perhaps downloadFile() does not need begin hook #19

birdofpreyru opened this issue Nov 8, 2023 · 0 comments
Labels
On Hold Blocked for some reason. P2 Important issue.

Comments

@birdofpreyru
Copy link
Owner

The hook seems to return almost the same info as the downloadFile() promise, and also it is fired at about the same time the promise is resolved. Thus, perhaps, drop the hook, add to the promise any info which is in the hook, but not in the promise.

For additional context see #18 (comment)

@birdofpreyru birdofpreyru added P2 Important issue. On Hold Blocked for some reason. labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Hold Blocked for some reason. P2 Important issue.
Projects
None yet
Development

No branches or pull requests

1 participant