-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build not passing the "commonly found issues" check on Google Play Console #92
Comments
Same for me... for now you can continue and ignore the error... |
I did that because I'm only using this package for a very small and niche use-case, but I suspect that if/when that function is called, it will crash on some devices. |
Hey @AdamGerthel, do you face it with the latest library version? The issue, indeed, used to be around for some time; however, I've noticed and fixed it back in v2.29.1. Related code now reads: react-native-fs/android/src/main/java/com/drpogodin/reactnativefs/ReactNativeFsModule.kt Lines 176 to 177 in 036d76b
which is fine as per Android Studio: SDKs >= 35 are supposed to support .removeLast() , while for older SDKs it falls back for older alternative. I wonder, whether Google.Play's code analysis is subpar to the Android Studio, leading to a false positive, or am I missing something here?
|
Yes, I'm on 2.30.1. Have not used any older versions as this was the first time I used this fork. |
Ok. I believe, it should work as is just fine on all Android versions, despite the warning. I'll keep the ticket open for sometime, just as a reminder to additionally have an eye on it. |
Ok, thanks. Good to know! |
same here, fixed by ignoring it |
Update: After publishing an update of my Android app, for the first time since you reported this issue, and seeing how this Google.Play check annoyingly interrupts the publishing attempt until explicitly confirmed to proceed, I'll sure will remove the code line triggering that warning in the next library version. |
Yeah, sometimes you need to wait up to 15 minutes before it finds the issue and aborts the submission 😖 |
I just replaced react-native-fs with this package in order to get new arch support and I'm getting the following error mesage from Google Play:
I couldn't find any issues about this. Any idea how to solve it?
The text was updated successfully, but these errors were encountered: