New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check numeric instability #7

Open

cthoyt opened this issue Sep 8, 2017 · 0 comments

cthoyt commented Sep 8, 2017 •

edited

Loading

There must be a way to compute the log of the factorial directly to avoid dealing with ridiculous big numbers

MEN2017/weights.py

Line 71 in 1f77631

    
           return sum(logOfFactorialOfPredictionListStats) - sum(math.log(math.factorial(threeByThreeContingencyTable)))

At least, this code should be refactored since the pattern of sum log factorial is repeated many times throughout this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment