Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token's suggestions #59

Open
ventormo opened this issue Jul 2, 2019 · 1 comment
Open

Token's suggestions #59

ventormo opened this issue Jul 2, 2019 · 1 comment

Comments

@ventormo
Copy link

ventormo commented Jul 2, 2019

  1. It seems to me that the settings not enough the ability to completely disable the replacement of tokens.

  2. You did not think to change the syntax of tokens to a more exotic one? ${token} is used in too many projects and is de facto the standard for value substitution (along with %token%). This leads to a lot of conflicts.
    Could it be worth changing it to, for example, @ <token>? (I have never met such an variant).

  3. It is necessary to add a certain keyword/sequence of characters, which will say that this token should not be replaced.
    That is, if the user enters /s (or another) when requesting the ${very_very_long_long_token_name} token, the plugin does not touch this token.

@ventormo
Copy link
Author

ventormo commented Jul 2, 2019

Workaround for changing syntax:

projectmaker.py

L183 r = re.compile(r"\${[^}]*}") => r = re.compile(r"\&{[^}]*}")
L249 r = re.compile(r"\${" + token + "}") => r = re.compile(r"\&{" + token + "}")

&{new_syntax}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant