Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

Not working with Angular CLI >= 1.5.0 #35

Open
amir-alic opened this issue Mar 12, 2018 · 3 comments
Open

Not working with Angular CLI >= 1.5.0 #35

amir-alic opened this issue Mar 12, 2018 · 3 comments

Comments

@amir-alic
Copy link

Could you please update the library to work with newer CLI versions?

We were using CLI 1.4.7 (and everything was OK) but now when we upgrade to 1.5.0 (or newer e.g. 1.7.3) there are build errors.

We have upgraded to Angular 5 so have to use at least [email protected].

Error:
Module build failed: Error: node_modules\ng2-combobox\src\combo-box.module.ts is missing from the TypeScript compilation.
Please make sure it is in your tsconfig via the 'files' or 'include' property.
The missing file seems to be part of a third party library.
TS files in published libraries are often a sign of a badly packaged library.
Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv).

@shochdoerfer
Copy link
Member

Thanks for your feedback. Any chance that you could provide a PR?

@amir-alic
Copy link
Author

amir-alic commented Mar 15, 2018

I am currently using a workaround by adding the index.ts in tsconfig.json (and tsconfig.spec.json for unit tests):

"files": [
    "node_modules/ng2-combobox/index.ts",    
     ...
  ]

@shochdoerfer
Copy link
Member

It'll be great if you could provide a PR to make this project compatible with the latest Angular CLI release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants