From b4b01d3fb42e7b688d97b75f57cfe18cfca6d943 Mon Sep 17 00:00:00 2001 From: kevkevin Date: Mon, 6 Nov 2023 20:39:03 -0600 Subject: [PATCH] [refactor] updating miniminer comments to be more accurate --- src/node/mini_miner.h | 8 ++++---- src/test/miniminer_tests.cpp | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/node/mini_miner.h b/src/node/mini_miner.h index 67d40b2cce3..de62c0af758 100644 --- a/src/node/mini_miner.h +++ b/src/node/mini_miner.h @@ -137,10 +137,10 @@ class MiniMiner */ MiniMiner(const CTxMemPool& mempool, const std::vector& outpoints); - /** Constructor in which the MiniMinerMempoolEntry entries have been constructed manually, - * presumably because these transactions are not in the mempool (yet). It is assumed that all - * entries are unique and their values are correct, otherwise results computed by MiniMiner may - * be incorrect. Callers should check IsReadyToCalculate() after construction. + /** Constructor in which the MiniMinerMempoolEntry entries have been constructed manually. + * It is assumed that all entries are unique and their values are correct, otherwise results + * computed by MiniMiner may be incorrect. Callers should check IsReadyToCalculate() after + * construction. * @param[in] descendant_caches A map from each transaction to the set of txids of this * transaction's descendant set, including itself. Each tx in * manual_entries must have a corresponding entry in this map, and diff --git a/src/test/miniminer_tests.cpp b/src/test/miniminer_tests.cpp index 036d3b5d5d3..2531ea7c47e 100644 --- a/src/test/miniminer_tests.cpp +++ b/src/test/miniminer_tests.cpp @@ -646,7 +646,7 @@ BOOST_FIXTURE_TEST_CASE(manual_ctor, TestChain100Setup) CTxMemPool& pool = *Assert(m_node.mempool); LOCK2(cs_main, pool.cs); { - // 3 pairs of fee-bumping grandparent + parent, plus 1 low-feerate child. + // 3 pairs of grandparent + fee-bumping parent, plus 1 low-feerate child. // 0 fee + high fee auto grandparent_zero_fee = make_tx({{m_coinbase_txns.at(0)->GetHash(), 0}}, 1); auto parent_high_feerate = make_tx({{grandparent_zero_fee->GetHash(), 0}}, 1); @@ -692,7 +692,7 @@ BOOST_FIXTURE_TEST_CASE(manual_ctor, TestChain100Setup) BOOST_CHECK_EQUAL(sequences.at(grandparent_double_low_feerate->GetHash()), 1); BOOST_CHECK_EQUAL(sequences.at(parent_med_feerate->GetHash()), 1); - // CPFP low + med + // CPFP low + double low BOOST_CHECK_EQUAL(sequences.at(grandparent_low_feerate->GetHash()), 2); BOOST_CHECK_EQUAL(sequences.at(parent_double_low_feerate->GetHash()), 2);