Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stuff from crates/chain/tests/common to bdk_testenv and make them publicly-accessible #1602

Closed
evanlinjin opened this issue Sep 12, 2024 · 3 comments · Fixed by #1612
Closed

Move stuff from crates/chain/tests/common to bdk_testenv and make them publicly-accessible #1602

evanlinjin opened this issue Sep 12, 2024 · 3 comments · Fixed by #1612
Assignees
@tvpeter
Labels
good first issue Good for newcomers tests
Milestone
1.0.0-beta

Comments

@evanlinjin
Copy link
Member

Describe the enhancement

These macros, fake-tx-construction-tools are helpful in other crates too. Let's move them to bdk_testenv and make them publicly available.

Use case

Better test tooling.
@evanlinjin evanlinjin added new feature New feature or request good first issue Good for newcomers tests labels Sep 12, 2024
@evanlinjin evanlinjin changed the title Move stuff from crates/chain/tests/common to bdk_testenv and make them publicly-accessable Move stuff from crates/chain/tests/common to bdk_testenv and make them publicly-accessible Sep 12, 2024
@evanlinjin evanlinjin mentioned this issue Sep 12, 2024
Merged
4 tasks
@tvpeter
Copy link
Contributor

tvpeter commented Sep 13, 2024

@evanlinjin I would like to work on this issue.

@evanlinjin
Copy link
Member Author

@tvpeter all yours!

tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 14, 2024
@tvpeter
Move tx testing utils to testenv crate
c97c3ea 
- add `tx_utils` to house all transaction
utilities moved from `crates/chain/test/common`
- deleted all moved macros and functions in
`crates/chain/test/common/mod`
- add `bitcoin` crate to `testenv` crate
- add `tx_utils` mod to lib in testenv

[Issue: bitcoindevkit#1602]
tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 14, 2024
@tvpeter
Import & use tx utils from testenv in chain crate
b65f74b 
- import testenv crate in chain crate
- replace all macros and fns in the following
tests with import from testenv crate
    - tests/test_indexed_tx_graph
    - tests/test_keychain_txout_index
    - tests/test_local_chain
    - tests/test_tx_graph
    - tests/test_tx_graph_conflicts

[issue: bitcoindevkit#1602]
tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 14, 2024
@tvpeter
Replace block_id macro def with testenv tx util
e26be1e 
- import testenv crate
- delete common module and import `block_id` from
testenv crate

[issue: bitcoindevkit#1602]
@tvpeter tvpeter mentioned this issue Sep 14, 2024
Merged
8 tasks
@tvpeter
Copy link
Contributor

tvpeter commented Sep 14, 2024

@evanlinjin, can you please review the PR here. I can't tag you there because the workflows require approval from a maintainer.

Thank you.

tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 15, 2024
@tvpeter
Refactor(test): Move tx test utils to testenv
3440237 
- add `tx_utils` to house all transaction
utilities moved from `crates/chain/test/common`
- deleted all moved macros and functions in
`crates/chain/test/common/mod`
- add `bitcoin` crate to `testenv` crate
- add `tx_utils` mod to lib in testenv

[Issue: bitcoindevkit#1602]
tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 15, 2024
@tvpeter
Refactor: use tx utils from testenv in chain crate
0f49254 
- import testenv crate in chain crate
- replace all macros and fns in the following
tests with import from testenv crate
    - tests/test_indexed_tx_graph
    - tests/test_keychain_txout_index
    - tests/test_local_chain
    - tests/test_tx_graph
    - tests/test_tx_graph_conflicts

[issue: bitcoindevkit#1602]
tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 15, 2024
@tvpeter
Refactor: Replace block_id macro def with tx util
b571fb0 
- import testenv crate
- delete common module and import `block_id` from
testenv crate

[issue: bitcoindevkit#1602]
@notmandatory notmandatory added this to BDK Sep 15, 2024
@notmandatory notmandatory moved this to In Progress in BDK Sep 15, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Sep 15, 2024
tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 16, 2024
@tvpeter
Refactor: replace bitcoin with bdk_chain::bitcoin
07d931f 
replace external crate `bitcoin` with re-exported
`bdk_chain::bitcoin`

[Ticket: bitcoindevkit#1602]
tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 16, 2024
@tvpeter
Refactor(test): Move tx test utils to testenv
016692e 
- add `tx_utils` to house all transaction
utilities moved from `crates/chain/test/common`
- deleted all moved macros and functions in
`crates/chain/test/common/mod`
- add `bitcoin` crate to `testenv` crate
- add `tx_utils` mod to lib in testenv

[Issue: bitcoindevkit#1602]
tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 16, 2024
@tvpeter
Refactor: use tx utils from testenv in chain crate
4b155bc 
- import testenv crate in chain crate
- replace all macros and fns in the following
tests with import from testenv crate
    - tests/test_indexed_tx_graph
    - tests/test_keychain_txout_index
    - tests/test_local_chain
    - tests/test_tx_graph
    - tests/test_tx_graph_conflicts

[issue: bitcoindevkit#1602]
tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 16, 2024
@tvpeter
Refactor: Replace block_id macro def with tx util
f2bf084 
- import testenv crate
- delete common module and import `block_id` from
testenv crate

[issue: bitcoindevkit#1602]
tvpeter added a commit to tvpeter/bdk that referenced this issue Sep 16, 2024
@tvpeter
Refactor: replace bitcoin with bdk_chain::bitcoin
23ae7bb 
replace external crate `bitcoin` with re-exported
`bdk_chain::bitcoin`

[Ticket: bitcoindevkit#1602]
@notmandatory notmandatory removed the new feature New feature or request label Sep 18, 2024
tvpeter added a commit to tvpeter/bdk that referenced this issue Oct 1, 2024
@tvpeter
Refactor(test): Move tx test utils to testenv
78d078a 
- add `tx_utils` to house all transaction
utilities moved from `crates/chain/test/common`
- deleted all moved macros and functions in
`crates/chain/test/common/mod`
- add `bitcoin` crate to `testenv` crate
- add `tx_utils` mod to lib in testenv

[Issue: bitcoindevkit#1602]

Refactor: use tx utils from testenv in chain crate

- import testenv crate in chain crate
- replace all macros and fns in the following
tests with import from testenv crate
    - tests/test_indexed_tx_graph
    - tests/test_keychain_txout_index
    - tests/test_local_chain
    - tests/test_tx_graph
    - tests/test_tx_graph_conflicts

[issue: bitcoindevkit#1602]

Refactor: Replace block_id macro def with tx util

- import testenv crate
- delete common module and import `block_id` from
testenv crate

[issue: bitcoindevkit#1602]

Refactor: replace bitcoin with bdk_chain::bitcoin

replace external crate `bitcoin` with re-exported
`bdk_chain::bitcoin`

[Ticket: bitcoindevkit#1602]

Refactor: rename `tx_utils` to `utils` in testenv

- Rename `tx_utils.rs` to `utils.rs` in `testenv`
to allow all testing utilities to be included.
- update all imports

[Ticket: X]

Refactor: move DESCRIPTORS sample array to testenv

move `DESCRIPTORS` sample array to `testenv` for
other crates to use

[Ticket: X]
tvpeter added a commit to tvpeter/bdk that referenced this issue Oct 3, 2024
@tvpeter
refactor(test): move tx test utils to testenv
e140f25 
- add `utils` mod to testenv crate to keep all
utilities moved from `crates/chain/test/common`
- replace all test tx macros in `chain` crate with
import from `testenv` crate
    - tests/test_indexed_tx_graph
    - tests/test_keychain_txout_index
    - tests/test_local_chain
    - tests/test_tx_graph
    - tests/test_tx_graph_conflicts
- deleted all moved macros and functions in
`crates/chain/test/common/mod`
- replace `bitcoin` external crate with
`bd_chain::bitcoin`
- move `DESCRIPTORS` sample array to `utils` for
other crates to use
- rename h! macro to hash! for clarity

[Ticket: bitcoindevkit#1602]
tvpeter added a commit to tvpeter/bdk that referenced this issue Oct 3, 2024
@tvpeter
refactor(test): move tx test utils to testenv
88a8403 
- add `utils` mod to testenv crate to keep all
utilities moved from `crates/chain/test/common`
- replace all test tx macros in `chain` crate with
import from `testenv` crate
    - tests/test_indexed_tx_graph
    - tests/test_keychain_txout_index
    - tests/test_local_chain
    - tests/test_tx_graph
    - tests/test_tx_graph_conflicts
- deleted all moved macros and functions in
`crates/chain/test/common/mod`
- replace `bitcoin` external crate with
`bd_chain::bitcoin`
- move `DESCRIPTORS` sample array to `utils` for
other crates to use
- rename h! macro to hash! for clarity
- rename localchain! macro parameter from
'block_hash' to 'hash'

[Ticket: bitcoindevkit#1602]
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tvpeter tvpeter

Labels
good first issue Good for newcomers tests
Projects
BDK
Archived in project
Milestone
1.0.0-beta
3 participants
@notmandatory @evanlinjin @tvpeter