ci: fix build-test job with --no-default-features, add miniscript/no-std #1636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the CI
build-test
job with--no-default-features
by also adding--features miniscript/no-std
.Until
rust-miniscript
removes theno-std
feature we need to enable it when--no-default-features
is used to buildbdk_wallet
or the whole workspace. See also thecheck-no-std
job which does the same plus enables thebdk_chain/hashbrown
feature which is also needed to buildbdk_wallet
with--no-default-features
but is already enabled when building the whole workspace.Notes to the reviewers
I think we didn't catch this on #1625 because the CI job names changed and I didn't update the branch merge requirements. Another possibility is it was passing because of cached build artifacts which I removed last night when I was trying to troubleshoot something else. I've updated the required CI jobs that need to pass before allowing a PR to be merged to
master
to include the ones with--no-default-features --features bdk_chain/hashbrown
in the name.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing