Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong usage of string(xxxx) #148

Open
gpmn opened this issue Jan 18, 2019 · 1 comment
Open

wrong usage of string(xxxx) #148

gpmn opened this issue Jan 18, 2019 · 1 comment

Comments

@gpmn
Copy link

gpmn commented Jan 18, 2019

req.Params.Add("end", string(end))
req.Params.Add("start", string(start))
req.Params.Add("limit", string(limit))
req.Params.Add("sort", string(sort))

req.Params.Add("end", string(end))
req.Params.Add("start", string(start))
req.Params.Add("limit", string(limit))
req.Params.Add("sort", string(sort))

should be changed to fmt.Sprintf("%d", end),
string(100) ==> "d"
string(101) ==> "e"
that's not your wish.

@gpmn
Copy link
Author

gpmn commented Feb 13, 2019

https://github.com/gpmn/bitfinex-api-go/blob/135a91fc446e18a239703ab5043b0e20e3f137dc/v2/rest/candles.go#L100

I fixed it, also I have changed somthing other than this issue, unless this, the these four args are all wrong.
You can refer my branch, wish it could be a little help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant