Websocket doesn't reconnect

[calj]

Issue type

• bug
• missing functionality
• performance
• feature request

Brief description

The websocket connection doesn't reconnect after heartbeat failure

Steps to reproduce

• Heatbeat timeout
• Expect: the websocket to reconnect
• Actual: there is no attempt to reconnect

Additional Notes:

• Connection parameters:

2020/07/15 08:51:07 ----Bitfinex Client Parameters----
2020/07/15 08:51:07 AutoReconnect=true
2020/07/15 08:51:07 CapacityPerConnection=%!t(int=25)
2020/07/15 08:51:07 ReconnectInterval=1s
2020/07/15 08:51:07 ReconnectAttempts=100
2020/07/15 08:51:07 ShutdownTimeout=5s
2020/07/15 08:51:07 ResubscribeOnReconnect=true
2020/07/15 08:51:07 HeartbeatTimeout=30s
2020/07/15 08:51:07 URL=wss://api-pub.bitfinex.com/ws/2
2020/07/15 08:51:07 ManageOrderbook=false
2020/07/15 08:51:07 connecting ws to %s wss://api-pub.bitfinex.com/ws/2

• Logs of heartbeat disconnection:

2020/07/15 07:52:58 heartbeat disconnect: heartbeat disconnect on channel 127518 expired at 2020-07-15 07:52:55.544034174 +0000 UTC m=+68428.569056686 (30s timeout)
2020/07/15 07:52:58 restarting socket (id=0) connection
2020/07/15 07:52:58 heartbeat disconnect: heartbeat disconnect on channel 127520 expired at 2020-07-15 07:52:57.696510702 +0000 UTC m=+68430.721533217 (30s timeout)
2020/07/15 07:52:58 heartbeat disconnect: heartbeat disconnect on channel 127522 expired at 2020-07-15 07:52:55.54404183 +0000 UTC m=+68428.569064344 (30s timeout)
2020/07/15 07:52:58 heartbeat disconnect: heartbeat disconnect on channel 126566 expired at 2020-07-15 07:52:55.544025443 +0000 UTC m=+68428.569047959 (30s timeout)
2020/07/15 07:52:58 heartbeat disconnect: heartbeat disconnect on channel 127516 expired at 2020-07-15 07:52:55.544030191 +0000 UTC m=+68428.569052706 (30s timeout)
2020/07/15 07:52:58 heartbeat disconnect: heartbeat disconnect on channel 127517 expired at 2020-07-15 07:52:55.544032253 +0000 UTC m=+68428.569054766 (30s timeout)
2020/07/15 07:52:58 heartbeat disconnect: heartbeat disconnect on channel 127519 expired at 2020-07-15 07:52:57.296680943 +0000 UTC m=+68430.321703456 (30s timeout)
2020/07/15 07:52:58 heartbeat disconnect: heartbeat disconnect on channel 127521 expired at 2020-07-15 07:52:55.544039792 +0000 UTC m=+68428.569062307 (30s timeout)
2020/07/15 07:52:58 heartbeat disconnect: heartbeat disconnect on channel 127485 expired at 2020-07-15 07:52:57.676450146 +0000 UTC m=+68430.701472661 (30s timeout)
2020/07/15 07:53:03 socket (id=0) took too long to close.

[JacobPlaster]

Thanks again @calj we will will take a look into this one too

[calj]

This problem might be caused by this missing unlock:
https://github.com/bitfinexcom/bitfinex-api-go/pull/219/files#diff-93015be9a1b3ee72156236756317284dR332

[JacobPlaster]

Nice spot @calj. Merged your PR, could you retry?