Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add a brand new Tapsigner #6077

Open
ppppso opened this issue Feb 13, 2025 · 4 comments
Open

Unable to add a brand new Tapsigner #6077

ppppso opened this issue Feb 13, 2025 · 4 comments
Assignees
Labels
bug🐛 did not exist in previous release but now it is. Status: to-do 📋 Items not yet picked up User 🤨 Additional label if it is a user reported item
Milestone

Comments

@ppppso
Copy link

ppppso commented Feb 13, 2025

Describe the bug
Unable to add a brand new Tapsigner

To Reproduce

  1. Go to Keys/Add key/Add key from a hardware/Tapsigner
  2. Enter pin code printed on the back
  3. Scan the card via NFC
  4. Error Unknown card protocol version is displayed and it's not possible to move forward

Expected behavior
It should be possible to add a brand new Tapsigner

Smartphone

  • Device: Samsung
  • OS: Android 14
  • Bitcoin Keeper: 2.0

Additional context
The Tapsigner was working fine. I was able to successfully set it up in Nunchuk and, once setup, worked perfectly in Bitcoin Keeper.

@ppppso ppppso added the Status: to-do 📋 Items not yet picked up label Feb 13, 2025
@ben-kaufman ben-kaufman self-assigned this Feb 13, 2025
@ben-kaufman ben-kaufman added this to the Sprint 45 milestone Feb 13, 2025
@ben-kaufman ben-kaufman added User 🤨 Additional label if it is a user reported item bug🐛 did not exist in previous release but now it is. labels Feb 13, 2025
@ben-kaufman
Copy link
Collaborator

Hi, thanks for reporting the issue.

I have tested with a new Tapsigner, but could not reproduce the issue. Can you please confirm if it was happening with various attempts or only once?

@ppppso
Copy link
Author

ppppso commented Feb 14, 2025

I tried many times, restarted the app, the phone,... but always the same issue and could never finish the setup. I checked the card one more time and, while it was never used, I'm not sure if it's the latest model or not. The card says version 1.0.3.

@ben-kaufman
Copy link
Collaborator

Ok, thank you for confirming.

So the version 1.0.3 should work and we have tested with it. The error message you are sharing only occurs when the protocol version the card returns is invalid, but that is also checked after the setup process, so if it works after setting up the card it means the protocol version it returns was updated. Let me check with the Tapsigner code if there may be any step to update the protocol version on setup and I'll update here.

@ppppso
Copy link
Author

ppppso commented Feb 14, 2025

My guess was that the app was expecting the protocol version and the Tapsigner was returning something else and thus failed. Maybe under some conditions the card behaves differently? In any case Nunchuk was able to handle the setup correctly so whatever it was must be something standard.

@ben-kaufman ben-kaufman modified the milestones: Sprint 45, Sprint 46 Feb 14, 2025
@ben-kaufman ben-kaufman modified the milestones: Sprint 46, Sprint 47 Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 did not exist in previous release but now it is. Status: to-do 📋 Items not yet picked up User 🤨 Additional label if it is a user reported item
Projects
None yet
Development

No branches or pull requests

2 participants