Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be a Django 3.0 support? #53

Open
Kenan7 opened this issue Mar 23, 2020 · 3 comments
Open

Will there be a Django 3.0 support? #53

Kenan7 opened this issue Mar 23, 2020 · 3 comments

Comments

@Kenan7
Copy link

Kenan7 commented Mar 23, 2020

I modified most part (on_delete argument) and so on but could not get my head around django.utils.functional.curry. I could not even find anything about it on google. I actually can write the 3.0 patch myself and make PR if someone provides me information about curry.

@Kenan7
Copy link
Author

Kenan7 commented Mar 23, 2020

Fixed most errors,

  • changed curry to functools.partial

  • changed assignment_tag to simple_tag

  • added path, re_path support for urls

./manage.py migrate is successful,

I can create a review, it's is just this last error when creating rating_category - >

File "/home/kenan/django/prj/env/lib/python3.6/site-packages/hvad/forms.py", line 217, in translatable_modelform_factory
    klass = modelform_factory(model, form, *args, **kwargs)
TypeError: modelform_factory() got an unexpected keyword argument 'change'
[23/Mar/2020 13:38:08] "GET /admin/review/ratingcategory/add/ HTTP/1.1" 500 13093

@BoPeng
Copy link

BoPeng commented Feb 15, 2021

@Kenan7 Do you have a fork or a PR for what you have already done?

@BoPeng
Copy link

BoPeng commented Feb 15, 2021

KristianOellegaard/django-hvad#365 (comment)

I think the underlying problem is that hvad, one of the dependencies of django-review has died, and will not support django >= 2.0. So if translation is not required, this dependency should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants