Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

We are hitting this as well with the upgrade to 8.8.3. I am not certain why this is suddenly an issue as the diffs on artifacthub don't show anything that would cause it. It seems to be a problem for both azure and azure-private-dns`

Also seeing this issue. I noticed that while the chart bump was just a patch increase 8.8.2 to 8.8.3, this actually bumped the underlying version of external-dns from 0.16.1 to 0.17.0. You'd think this would constitute an equal bump in the chart version to 8.9.0 but I guess not?

I suspect there was some change to the code which parses the JSON file, and that prior to 0.17.0 this was incorrectly parsing this file with a trailing comma as valid JSON. Looking at another cluster still running 0.16.1, I can also see the file has a trailing comma, and isn't causing this issue. The fix to me seems to be that it should not generate with a trailing comma.

Looking at the _helpers.tpl function which generates the contents of the secret, it looks to be generating a raw JSON string, which is probably not the best way to do that.

I will open a PR soon to convert this function to generate a native templating dictionary, and then convert that to JSON, so that the values can be in any order, and we don't need to worry about trailing commas.

A rough POC of what I'm thinking:

{{- define "external-dns.azure-credentials" -}}
{{- $credentials := dict -}}
{{- if .Values.azure.cloud -}}
{{- $_ := set $credentials "cloud" .Values.azure.cloud -}}
{{- end -}}
{{- if .Values.azure.tenantId -}}
{{- $_ := set $credentials "tenantId" .Values.azure.tenantId -}}
{{- end -}}
{{- if .Values.azure.subscriptionId -}}
{{- $_ := set $credentials "subscriptionId" .Values.azure.subscriptionId -}}
{{- end -}}
{{- $_ := set $credentials "resourceGroup" .Values.azure.resourceGroup -}}
{{- if not (or .Values.azure.useManagedIdentityExtension .Values.azure.useWorkloadIdentityExtension) -}}
{{- $_ := set $credentials "aadClientId" .Values.azure.aadClientId -}}
{{- $_ := set $credentials "aadClientSecret" .Values.azure.aadClientSecret -}}
{{- end -}}
{{- if .Values.azure.useWorkloadIdentityExtension -}}
{{- $_ := set $credentials "useWorkloadIdentityExtension" true -}}
{{- end -}}
{{- if and .Values.azure.useManagedIdentityExtension .Values.azure.userAssignedIdentityID -}}
{{- $_ := set $credentials "useManagedIdentityExtension" true -}}
{{- $_ := set $credentials "userAssignedIdentityID" .Values.azure.userAssignedIdentityID -}}
{{- else if and .Values.azure.useManagedIdentityExtension (not .Values.azure.userAssignedIdentityID) -}}
{{- $_ := set $credentials "useManagedIdentityExtension" true -}}
{{- end -}}
{{- $credentials | toJsonPretty -}}
{{- end -}}

That's kind of what I was thinking. I'm wondering though if you can just

{{ omit .Values.azure "secretName" | toJsonPretty }} 

Since all the values of the azure object are one-to-one mappings with that file except for the secretName. I think after all that logic is performed you literally just end up with a clone of the object. You probably wouldn't set any of the values if you didn't expect them in the config file

That's kind of what I was thinking. I'm wondering though if you can just

{{ omit .Values.azure "secretName" | toJsonPretty }} 

Since all the values of the azure object are one-to-one mappings with that file except for the secretName. I think after all that logic is performed you literally just end up with a clone of the object. You probably wouldn't set any of the values if you didn't expect them in the config file

Yes that's a much more elegant solution! I should have a PR submitted by tonight.