Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApproximatedSize returns wrong bloom filter size if bloom filter has 4B+(beyond uint32 range) items #103

Open
satishbhor opened this issue Jun 11, 2024 · 0 comments · May be fixed by #102
Open

ApproximatedSize returns wrong bloom filter size if bloom filter has 4B+(beyond uint32 range) items #103

satishbhor opened this issue Jun 11, 2024 · 0 comments · May be fixed by #102

Comments

@satishbhor
Copy link

This is happing because we are type casting bloom filter size estimation to uint32 and its rounding numbers back to within uint32 range,
we should prefer to typecast it to uint64 so that it can derive correct result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix size estimation if bloom filter has items beyond uint32 range satishbhor/bloom
1 participant
@satishbhor