Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Price Alerts to Stop-Loss/Take-Profit orders #2240

Open
sschiessl-bcp opened this issue Nov 29, 2018 · 5 comments
Open

Expand Price Alerts to Stop-Loss/Take-Profit orders #2240

sschiessl-bcp opened this issue Nov 29, 2018 · 5 comments
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Needs Discussion More discussion is required before implemented or worked on [3] Feature Classification indicating the addition of novel functionality to the design [5d] Large Indicates size of task. Est. between four and ten hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting

Comments

@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Nov 29, 2018 •
edited
Loading

The price alerts of the latest version can be expanded into stop-loss and take-profit orders.

Idea:
Price alerts get a "add order" button, which signs a respective sell order on price alert creation, but does not broadcast it. It will only get broadcast when the price alert is triggered. It could also ask the user to sign when the price alert is triggered, but that forces a split second decision of the user, which would be unfavorible.

Thoughts?

Related
#406
@startailcoon
Copy link
Contributor

Would be a cool feature if possible to implement. The lack of Stop-Loss and Take-Profit orders in core is a significant limitation for the platform.

This would require the wallet to be online to work, right?

@startailcoon startailcoon added [3] Feature Classification indicating the addition of novel functionality to the design [1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Needs Discussion More discussion is required before implemented or worked on labels Dec 1, 2018
@sschiessl-bcp
Copy link
Contributor Author

Yes, continuous connection would be necessary

@startailcoon startailcoon added this to the 190131 milestone Dec 15, 2018
@startailcoon startailcoon added [5d] Large Indicates size of task. Est. between four and ten hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Dec 15, 2018
@startailcoon startailcoon changed the title Expand Price Alerts to Stop-Loss/Take-Profit orders [5] Expand Price Alerts to Stop-Loss/Take-Profit orders Dec 15, 2018
@startailcoon startailcoon modified the milestones: 190131, 190227 Feb 12, 2019
@startailcoon startailcoon modified the milestones: 190301, 190315 Mar 9, 2019
@clockworkgr clockworkgr modified the milestones: 190315, 190329 Mar 20, 2019
@clockworkgr clockworkgr modified the milestones: 190329, 190412 Apr 3, 2019
@startailcoon startailcoon modified the milestones: 190412, 190510 Apr 14, 2019
@startailcoon startailcoon modified the milestones: 190510, 190705 May 22, 2019
@startailcoon
Copy link
Contributor

Pushed to July to add some discussion time for this issue.

@abitmore
Copy link
Member

which signs a respective sell order

Maximum expiration time of a transaction is one day. Oldest possible TaPoS header is 65535 blocks old. So the user can not sign the order too early. Maybe best experience requires user keeping the wallet online and unlocked?

The lack of Stop-Loss and Take-Profit orders in core

See bitshares/bsips#170 (comment) "a stop-loss order, which is known to be dangerous if publicly known in advance."

@startailcoon startailcoon changed the title [5] Expand Price Alerts to Stop-Loss/Take-Profit orders Expand Price Alerts to Stop-Loss/Take-Profit orders May 29, 2019
@sschiessl-bcp
Copy link
Contributor Author

Maximum expiration time of a transaction is one day. Oldest possible TaPoS header is 65535 blocks old. So the user can not sign the order too early. Maybe best experience requires user keeping the wallet online and unlocked?

Both cases would require the user to have the wallet open. User should not have to login or enforce that the wallet remains unlocked when leaving it open for Stop-Loss/Take-Profit. In general the question is if that is even desirable for an everyday trader (need to leave wallet open), and if it is he would need to re-sign the Stop-Loss/Take-Profit every 24hours. When Custom Active is ready there will be more secure alternatives to build a Stop-Loss/Take-Profit centralized service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[1b] User Story The User Story details a requirement. It may ref a parent Project (Epic). It may ref child Task(s) [2] Needs Discussion More discussion is required before implemented or worked on [3] Feature Classification indicating the addition of novel functionality to the design [5d] Large Indicates size of task. Est. between four and ten hours [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clockworkgr @abitmore @startailcoon @sschiessl-bcp