Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2662 Integration of New Login #2675

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

#2662 Integration of New Login #2675

wants to merge 6 commits into from

Conversation

gibbsfromncis
Copy link
Contributor

General

Closes #2662
  • Remove old routes
  • Replace old routes by new
  • Add link to restore brain-key on Home Login page because it was only in old component which is removed

Code Preparation

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

  • Chrome
  • Opera
  • Firefox
  • Safari

Screenshot 2019-05-10 11 14 23

@sschiessl-bcp
Copy link
Contributor

Did you implement the mobile version as always visible, or just as is?

@sschiessl-bcp sschiessl-bcp force-pushed the develop branch 9 times, most recently from b056a17 to fd99821 Compare March 18, 2022 15:34
@sschiessl-bcp sschiessl-bcp force-pushed the develop branch 2 times, most recently from bc2f1ad to d0a0996 Compare April 23, 2022 09:32
@abitmore
Copy link
Member

@sschiessl-bcp looks like the code change in this PR is quite small. Can we merge it?

@sschiessl-bcp
Copy link
Contributor

This PR enables this login version

https://develop.bitshares.org/#/login
image

@abitmore
Copy link
Member

Yeah, I think it looks good. @sschiessl-bcp what do you think?

@abitmore
Copy link
Member

And also this registration version https://develop.bitshares.org/#/registration
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.5] New Login integration to route
3 participants
@gibbsfromncis @sschiessl-bcp @abitmore