Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology tests - nodes should not be able to adjust to nodes that have not started #656

Closed
rslawson opened this issue Oct 22, 2024 · 2 comments

Comments

@rslawson
Copy link
Collaborator

rslawson commented Oct 22, 2024

Going by the graphs from the topology tests (both software and hardware) appear to allow nodes to adjust to the frequency of nodes that have not finished their delay period. Of note is the hourglass topology - as @kleinreact pointed out, it appears that nodes with no startup delay (starting at -100ppm relative frequency) are adjusting to the frequency of the nodes that have a 1.6s startup delay:
image

Probably worth fixing.

@rslawson
Copy link
Collaborator Author

This is now fixed in the SwCc branch for the software topologies test (#654). I'll add the fix into the HwCc test separately in another PR.

@rslawson
Copy link
Collaborator Author

Scratch that, actually. I forgot that once SwCc is merged, the HwCc tests will be removed, so that's unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant