Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 #8

Open
wimurk opened this issue Oct 14, 2021 · 0 comments
Open

PHP 8 #8

wimurk opened this issue Oct 14, 2021 · 0 comments

Comments

@wimurk
Copy link

wimurk commented Oct 14, 2021

WHen running the API in PHP 8 there are some methods that need to be changed.

For example the contruct method of the Websocket does not match the caller

public function newWebSocket($reconnect = false, $publicCommandArray = null, $privateCommandArray = null, $oldSocket = null) {
    $this->webSocket = new Websocket($this, $reconnect, $publicCommandArray, $privateCommandArray, $oldSocket);
    return $this->webSocket;
}

class Websocket {
  public function __construct($bitvavo = null, $reconnect = false, $publicCommandArray, $privateCommandArray, $oldSocket) {
       
  }
}

Changing the above to match the caller or change the caller to the constructor.

class Websocket {
  public function __construct($bitvavo = null, $reconnect = false, $publicCommandArray= null, $privateCommandArray = null, $oldSocket = null) {
       
  }
}

I will make a pull request to find other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant