Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Git tag associated with released versions #12

Open
amarshall opened this issue Oct 25, 2024 · 4 comments
Open

No Git tag associated with released versions #12

amarshall opened this issue Oct 25, 2024 · 4 comments

Comments

@amarshall
Copy link

Hi, this repo has associated versions in the NPM registry, but none here (and the package.json file has 0.0.0). This makes determining the source code associated with a registry release more difficult than it perhaps should be (though it can potentially be gleaned from the release workflow, this is not as trivial as just referencing a Git tag.

@Hinton
Copy link
Member

Hinton commented Nov 4, 2024

Hi @amarshall,

We partially solved this with #17 which includes the build id in the version number. This should allow easy mapping by getting the appropriate run in https://github.com/bitwarden/sdk-internal/actions/workflows/publish-wasm-internal.yml and checking the git hash. Is this satisfactory?

@amarshall
Copy link
Author

GitHub Actions logs are only retained for up to 90 days (see docs), so it only works for a limited period of time.

@brjsp
Copy link

brjsp commented Nov 11, 2024

@amarshall Thanks for alerting me to this. I've manually archived the existing versions at https://github.com/brjsp/sdk-internal/tags

(I'm not affiliated with Bitwarden but i maintain the package in openSUSE.)

@Hinton
Copy link
Member

Hinton commented Nov 11, 2024

Hmm, would including a VERSION file on npm, containing the git hash work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants