Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL UF8 - Avoid checking the Last Value in updateVuValue #84

Open
miditalk opened this issue Mar 22, 2024 · 0 comments
Open

SSL UF8 - Avoid checking the Last Value in updateVuValue #84

miditalk opened this issue Mar 22, 2024 · 0 comments

Comments

@miditalk
Copy link
Contributor

miditalk commented Mar 22, 2024

If Vu Value is not received for a certain period of time, UF8's level meter will turns off.
The level meter may not display correctly in certain situations, such as Pads sound.

private void updateVuValue(final int value) {
if (isActive() && value != lastValue) {
getTarget().sendVuUpdate(index, value);
}
lastValue = value;
}

I modified like this:

  • remove && value != lastValue
private void updateVuValue(final int value) { 
     if (isActive()) { 
         getTarget().sendVuUpdate(index, value); 
     } 
     lastValue = value; 
 } 
Bitwig_VU-.-1080P-30P.mp4
@miditalk miditalk changed the title SSL UF8 - It is better not to check the LastValue in updateVuValue SSL UF8 - Avoid checking the Last Value in updateVuValue Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant