Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: start moving bulk assing out of js modules #709

Merged
merged 14 commits into from
Sep 26, 2024
Merged

feat: start moving bulk assing out of js modules #709

merged 14 commits into from
Sep 26, 2024

Conversation

dreamfall
Copy link
Contributor

@dreamfall dreamfall commented Aug 19, 2024 •
edited
Loading

📝 A short description of the changes

  • move lieutenancy and assessor sub group bulk assignment to their own page to support non-js flow
  • add ability to change eligibility state in bulk

  • 🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

image image image image image image

dreamfall and others added 3 commits August 19, 2024 08:49
@dreamfall
feat: start moving bulk assing out of js modules
8533caa
@DaniBitZesty
- Converts 'Select award year' button to a select
1520429 
- Converts 'Remove filters' button to a link
- Hides table caption 'Nominations list' from display but keeps it accessible to screen readers
- Creates new h2 for 'Nominations list'
@DaniBitZesty
Debugging redirect_url not working
b97f0cc
@TheDancingClown TheDancingClown force-pushed the bulk-eligibility-status-change branch 3 times, most recently from 698a7eb to ed996e6 Compare September 21, 2024 16:34
@TheDancingClown TheDancingClown force-pushed the bulk-eligibility-status-change branch from ed996e6 to 3d2c2f1 Compare September 21, 2024 17:03
@dreamfall dreamfall force-pushed the bulk-eligibility-status-change branch from 0a33021 to 549e1f1 Compare September 25, 2024 10:45
@dreamfall dreamfall marked this pull request as ready for review September 26, 2024 06:52
@dreamfall dreamfall merged commit cfd0384 into main Sep 26, 2024
5 of 6 checks passed
@dreamfall dreamfall deleted the bulk-eligibility-status-change branch September 26, 2024 07:51
@TheDancingClown TheDancingClown mentioned this pull request Sep 30, 2024
Merged
@TheDancingClown TheDancingClown mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDancingClown TheDancingClown TheDancingClown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamfall @TheDancingClown @DaniBitZesty