Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProfileData when initializing state in riverpod #9

Open
jagare opened this issue Jul 2, 2021 · 1 comment
Open

ProfileData when initializing state in riverpod #9

jagare opened this issue Jul 2, 2021 · 1 comment

Comments

@jagare
Copy link

jagare commented Jul 2, 2021

In the riverpod version, the profilesDataProvider returns a new ProfileData when in initalizing state:
https://github.com/bizz84/movie_app_state_management_flutter/blob/main/apps/riverpod/lib/top_level_providers.dart#L19
This was introduced during null safety migration. This looks like a quick fix. I feel this should be handled in a more proper way. It would be interesting to see how...
@jagare
Copy link
Author

jagare commented Jul 4, 2021

As it is the ProfileSelectionPage contains dead code for showing a ProgressIndicator when profileData is null, which will never happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jagare