This repository was archived by the owner on May 19, 2022. It is now read-only.
Navbar Component and Generic Components #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce new HOC DomWrap - move WithRendererTag into CustomisableComponent
- Change alert links into new component - change headings into domWrap - get rid of classNameWrapper
…omponent. make usage of both even easier
…inds of handlers for them
- simplifiy component identification - remove ElementBuilder
…o sense - change alert into AbstractDomComponent although work is still needed. Child elements are currently available everywhere
- rename SuperAbstractDomComponent to DomComponent - make AbstractDomComponent extend DomComponent - fun interface for activeLinkPredicate - reduce visibility of alert sub components by using a custom domBuilder
- rename `mapComponents` to `onEachComponent` - optimise behaviour logic in ButtonGroup and add some useful comments
- rename occurences of dom to DOM
…mponent and CustomisableComponent
…ther headlines, better reference code
…-react-bootstrap module
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Groundwork for the navbar component is done.
Thing is: For the brand component I created the
DOMWrap. Which I can use for many more components, if not all.This would give the user to total control how bootstrap components should be rendered. PR is going to be huge
Oh Boy.. it does not stop. I also find a way to identify ReactElements without having to use "Identifiable"