Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A minor issue in the modified count_matrix.py #1

Open
Mingyuan00 opened this issue Nov 20, 2024 · 4 comments
Open

A minor issue in the modified count_matrix.py #1

Mingyuan00 opened this issue Nov 20, 2024 · 4 comments

Comments

@Mingyuan00
Copy link

Dear developer,

Thank you for sharing the code. It seems that in this modified version of deeptime for Girsanov reweighting, there is a minor indentation typo in the count_matrix.py script at line 77:

which will result in an indentation error when importing the modified package.

Best wishes
Mingyuan

@anyschaefer
Copy link
Collaborator

Dear Mingyuan,
Thank you very much for the hint. This deeptime repository is unfortunately not up to date. You can find the latest version as a commit to the main repository. Please use this version for your studies.
Best regards
Joana

@Mingyuan00
Copy link
Author

Dear Mingyuan, Thank you very much for the hint. This deeptime repository is unfortunately not up to date. You can find the latest version as a commit to the main repository. Please use this version for your studies. Best regards Joana

Dear Joana,
Thank you very much for your reply. I was actually directed from the reweightingtools repository. I am wondering if there is also an updated version of the openmmtools for the LangevinSplittingGirsanov class and the reporter function? It appears to me that it has not yet been merged to main repository and the link for the reporter function is currently not working.
Best wishes
Mingyuan

@anyschaefer
Copy link
Collaborator

Exactly we have started a pull request to the openmmtools repository. I have updated the reweightingtools readme for the latest structure and links. I hope now you can find everything you need to get started.

@Mingyuan00
Copy link
Author

Exactly we have started a pull request to the openmmtools repository. I have updated the reweightingtools readme for the latest structure and links. I hope now you can find everything you need to get started.

Great! Thank you very much for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants