Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many random seeds in my humble opinnion #1

Open
Niceno opened this issue Sep 7, 2018 · 0 comments
Open

Too many random seeds in my humble opinnion #1

Niceno opened this issue Sep 7, 2018 · 0 comments

Comments

@Niceno
Copy link

Niceno commented Sep 7, 2018

Dear Eugene,

I think you did a very nice job with implementation of the SED method. I took your sources, changed the variable names to my taste, and have played with them for a day. I wrote subroutines to export unsteady results to .vtk format (for Paraview, for example), but have noticed something unpleasant. After several dozens of time steps, your eddies somehow stop moving and solutions become practically steady :-(

I browsed through the source and noticed that you call RANDOM_SEED to often, meaning you start the same random sequence at each time step. I removed all calls to RANDOM_SEED and eddies started to move freely over and around the problem domain.

Cheers,

Bojan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant