Added some features #530
Closed
Added some features #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check is user already exists when create new user
* Run ater_failure script only if error * Run ater_success script only if no errors * Add color functions
|
|
jkuri
reviewed
Jun 16, 2021
jkuri
reviewed
Jun 16, 2021
| @@ -8,7 +8,7 @@ type ( | |||
| ID uint `gorm:"primary_key;auto_increment;not null" json:"id"` | |||
| Email string `gorm:"not null;size:255;unique_index" json:"email"` | |||
| Password string `gorm:"not null;size:255;column:password" json:"-"` | |||
| Name string `gorm:"not null;size:255" json:"name"` | |||
| Name string `gorm:"not null;size:255;unique_index" json:"name"` | |||
There was a problem hiding this comment.
this is not meant to be username originally, this is full name such as John Smith, I don't mind if you add additional property for username though.
There was a problem hiding this comment.
OK, I'm thinking to add "Login" field so that there won't be any confusion with "Name" later (and we wouldn't need to rename all occurrences of the Name -> Full Name later)
jkuri
reviewed
Jun 16, 2021
jkuri
reviewed
Jun 16, 2021
Porsh33
commented
Jun 17, 2021
| @@ -8,7 +8,7 @@ type ( | |||
| ID uint `gorm:"primary_key;auto_increment;not null" json:"id"` | |||
| Email string `gorm:"not null;size:255;unique_index" json:"email"` | |||
| Password string `gorm:"not null;size:255;column:password" json:"-"` | |||
| Name string `gorm:"not null;size:255" json:"name"` | |||
| Name string `gorm:"not null;size:255;unique_index" json:"name"` | |||
There was a problem hiding this comment.
OK, I'm thinking to add "Login" field so that there won't be any confusion with "Name" later (and we wouldn't need to rename all occurrences of the Name -> Full Name later)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after_successscript only if all previous scripts exit normally. Also runafter_failurescript immediately after any previous script exit with errors