Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

Possible bug/omission: APIRequestException not raised on status code 420 #14

Open
thecnoNSMB opened this issue Nov 15, 2018 · 4 comments

Comments

@thecnoNSMB
Copy link

thecnoNSMB commented Nov 15, 2018

Speedrun.com uses status code 420 to indicate that the client is being rate-limited. Details here. (I say "possible" because I have no idea how to test for this, but I'm pretty sure it's the reason my code failed.)

@thecnoNSMB
Copy link
Author

I should've suspected something when I typed "I think it's the library's fault that my code doesn't work." It's my fault and I'm an idiot. Still, I don't see any handling for this in the source, and this code should probably be being handled if it isn't already.

@blha303
Copy link
Owner

blha303 commented Nov 15, 2018

At the time I wrote srcomapi that throttling didn't exist. I'll add it to the list of things to improve.

@thecnoNSMB
Copy link
Author

Apologies for being an idiot, in any case.

@blha303
Copy link
Owner

blha303 commented Nov 15, 2018

No, you're fine, I should be catching throttling. I'll figure something out to fix it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants