Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding notes please only target the selected text and not the entire line. #205

Open
cary-rowen opened this issue Nov 24, 2022 · 7 comments · May be fixed by #280
Open

When adding notes please only target the selected text and not the entire line. #205

cary-rowen opened this issue Nov 24, 2022 · 7 comments · May be fixed by #280
Labels
Improvement Improving or fixing an existing feature

Comments

@cary-rowen
Copy link
Collaborator

Describe the Problem

I want to add notes to the selected text area (such as a specific term), but bookworm can only add notes to the entire line.

To Reproduce

Steps to reproduce the behavior:

  1. Open a document at random.
  2. Select a part of any line.
  3. Press Ctrl+M to write the note content and save it.
  4. Use the left or right arrows to view the line, you cannot see where the note start or end.

Expected behavior

notes can be added to selected text, just like highlighting.

If the problem is related to a file, indicate the file you have opened

None

Desktop (please complete the following information):

  • OS: [Windows 10 22H2 (x64) build 19045.2251]
  • Bookworm version [2022.1B3]
  • Recent settings you may have changed in Bookworm [None]

Additional context

None

@mush42
Copy link
Collaborator

mush42 commented Nov 24, 2022

@cary-rowen I'll check to see if this does not require a breaking change. If it doesn't, I'll implement it ASAP.

Best
Musharraf

@cary-rowen
Copy link
Collaborator Author

@mush42

OK, looking forward to your good news.

Best
Cary

@cary-rowen
Copy link
Collaborator Author

Hi, @mush42 will this feature be difficult to implement?

@mush42
Copy link
Collaborator

mush42 commented Dec 6, 2022

I don't think it will be hard to implement.
I will try to work on it ASAP.
I'm a bit busy at work these days. Please be patient with me.

@cary-rowen
Copy link
Collaborator Author

OK, thank you, my friend.
Anyway, please take care.

@cary-rowen
Copy link
Collaborator Author

Hi @mush42
Any progress on this issue?

@cary-rowen
Copy link
Collaborator Author

cc @pauliyobo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improving or fixing an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants