Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve decoding for CardanoDnsDomain #13

Open
agaffney opened this issue Nov 17, 2023 · 0 comments
Open

Improve decoding for CardanoDnsDomain #13

agaffney opened this issue Nov 17, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@agaffney
Copy link
Contributor

We are doing some unchecked type assertions that could cause a panic with bad record data. We can use temporary types to decode into to get an actual error we can return.

We should also move the individual record decoding to that object, but we need to be able to get a constructor's CBOR bytes.

@wolf31o2 wolf31o2 added the enhancement New feature or request label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants