Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anime4K isn't compatible with --vo=libmpv in memento #251

Open
eyalmazuz opened this issue Oct 1, 2024 · 3 comments
Open

Anime4K isn't compatible with --vo=libmpv in memento #251

eyalmazuz opened this issue Oct 1, 2024 · 3 comments

Comments

@eyalmazuz
Copy link

Describe the bug
When adding anime4K shaders to Memento
you can't use presets 1 and 2 and clear the shaders doesn't work

To Reproduce
Steps to reproduce the behavior:

  1. Go to Memento and clone the repo
  2. Compile from source and install memento
  3. download anime4K shaders and install in the memento config folder
  4. See error

Expected behavior
Anime4K should work flawalessly

~/D/J/A/[Judas] Kimetsu no Yaiba - Mugen Ressha-hen [1080p][HEVC x265 10bit][Multi-Subs]> memento \[Judas\]\ Kimetsu\ no\ Yaiba\ -\ Mugen\ Ressha-hen\ -\ 05.mkv
AO: [pipewire] 44100Hz stereo 2ch floatp
VO: [libmpv] 1920x1080 yuv420p10
[libmpv_render] after creating texture: OpenGL error INVALID_ENUM.
[mpv_thumbnail_script_client_osc] The 'tick' event is deprecated and will be removed.
[libmpv_render] before loading program: OpenGL error INVALID_ENUM.

Desktop (please complete the following information):

  • OS: Manajro Linux
  • Version: I guess anime4K version? the latest
  • GPU/Version: GTX 1650 Nvdia drivers version 550.107.02
  • Media Player and Version: Memento 1.4.1 and main
@Tama47
Copy link
Contributor

Tama47 commented Oct 8, 2024

you can't use presets 1 and 2 and clear the shaders doesn't work

This sounds like you may not have installed input.conf or mpv.conf in the correct location.
Screenshot 2024-10-07 at 21 40 05
Screenshot 2024-10-07 at 21 40 25
I've tested on both MacOS and Windows 11 (have not tested Linux), and Anime4K is working correctly with vo=libmpv.

@eyalmazuz
Copy link
Author

eyalmazuz commented Oct 8, 2024

you can't use presets 1 and 2 and clear the shaders doesn't work

This sounds like you may not have installed input.conf or mpv.conf in the correct location. ) I've tested on both MacOS and Windows 11 (have not tested Linux), and Anime4K is working correctly with vo=libmpv.

side note: in the image you show mode A+A which I said "works" (as in the text appears) mode A or mode B are the "problematic" ones

I'm experiencing an issue on linux, telling me it works on windows/macOS does not help, and I tested it on more than one machine so it's not a me-issue

Also I did install the conf files in the correct location
image

as per memento's instructions:
image

@Tama47
Copy link
Contributor

Tama47 commented Oct 8, 2024

side note: in the image you show mode A+A which I said "works" (as in the text appears) mode A or mode B are the "problematic" ones

I specifically chose Mode A+A so that you can clearly see the lines being sharper in the screenshots, thus implying that the shaders worked correctly. Mode A and B also worked in my testing.

I'm experiencing an issue on linux, telling me it works on windows/macOS does not help, and I tested it on more than one machine so it's not a me-issue

The only difference I had from your setup was that I put the option as a config in my mpv.conf file, and I was using a different operating system. And the result is that Anime4K is working as intended on both operating systems. Indicating that --vo=libmpv may just not be compatible with your specific Linux kernel. There’s nothing we can do to fix compatibility issues with libmpv itself as Anime4K is just a set of upscale shaders. mpv-player/mpv#15019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants