Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: introduce form injection for provider modals #1493

Merged
merged 7 commits into from
Mar 4, 2025

Conversation

lily-de
Copy link
Collaborator

@lily-de lily-de commented Mar 4, 2025

  • Moves files around
  • Gets rid of getActions in provider registry
  • Sets up using custom forms with custom submit buttons to handle the forms

no state related stuff -- tried but there's something not quite right with the config for providers (can't get keychain info), so next pr

@lily-de lily-de force-pushed the ldelalande/composable-modal branch from 2bf65ba to 9adfd88 Compare March 4, 2025 02:41
@lily-de lily-de changed the title Ldelalande/composable modal ui: introduce form injection for provider modals Mar 4, 2025
@lily-de lily-de marked this pull request as ready for review March 4, 2025 05:28
@michaelneale
Copy link
Collaborator

looks pretty reasonable - large one - what is best way to review?

@michaelneale
Copy link
Collaborator

.bundle

Copy link

github-actions bot commented Mar 4, 2025

macOS ARM64 Desktop App (Apple Silicon)

📱 Download macOS Desktop App (arm64, signed)

Instructions:
After downloading, unzip the file and drag the Goose.app to your Applications folder. The app is signed and notarized for macOS.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

* @param {string} [props.className] - Additional CSS classes for the main container
* @returns {JSX.Element}
*/
const CustomRadio = ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider if we should use this, and if we can unify with what I had here for the top level of the settings page model radio buttons

<input
type="radio"
name="model"
checked={model.selected}
onChange={() => handleModelSelect(model.id)}
className="h-4 w-4 text-white accent-[#393838] bg-[#393838] border-[#393838] checked:bg-[#393838] focus:ring-0 focus:ring-offset-0"
/>

@lily-de lily-de merged commit 689890d into main Mar 4, 2025
6 checks passed
@lily-de lily-de deleted the ldelalande/composable-modal branch March 4, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants