Merge pull request #17 from maxholman/types-2024-12-15

fix: improve typescript compat

Author: maxholman

packages/web-push/lib/types.ts

@@ -24,7 +24,9 @@ export type PushMessage<T extends Jsonifiable = Jsonifiable> = {
 
 export type PushSubscription = {
   endpoint: string;
-  expirationTime: null | DOMHighResTimeStamp;
+
+  /** DOMHighResTimeStamp */
+  expirationTime: number | null;
   keys: {
     auth: string; // secret
     p256dh: string; // key

packages/web-push/package.json

@@ -30,12 +30,12 @@
   },
   "dependencies": {
     "@block65/custom-error": "^12.2.0",
+    "type-fest": "^4.20.0",
     "base64-arraybuffer": "^1.0.2"
   },
   "devDependencies": {
     "@tsconfig/node20": "^20.1.4",
     "@types/node": "^20.14.2",
-    "type-fest": "^4.20.0",
     "vitest": "<=1.5.0"
   }
 }

packages/web-push/test/__snapshots__/notification.test.ts.snap

@@ -2,42 +2,42 @@
 
 exports[`buildPushPayload 1`] = `
 Uint8Array [
-  94,
-  43,
-  206,
-  12,
-  35,
-  84,
-  222,
-  164,
-  14,
-  84,
-  27,
-  103,
-  93,
-  135,
-  57,
-  15,
-  55,
-  130,
-  240,
-  181,
-  195,
-  28,
-  112,
-  112,
-  78,
-  204,
-  132,
-  168,
-  189,
-  200,
-  158,
-  205,
-  71,
-  53,
+  3,
+  190,
   254,
+  232,
+  87,
+  55,
+  210,
+  61,
+  25,
+  227,
+  75,
   197,
+  243,
+  37,
+  221,
+  53,
+  182,
+  76,
+  230,
+  68,
+  44,
+  50,
+  246,
+  235,
+  187,
+  191,
+  193,
+  141,
+  134,
+  128,
+  106,
+  42,
+  251,
+  15,
+  207,
+  153,
 ]
 `;
 

packages/web-push/test/fixtures.ts

@@ -3,12 +3,12 @@ import type { PushSubscription } from '../lib/types.js';
 export const fakeSubscriptions = {
   chrome: {
     endpoint:
-      'https://fcm.googleapis.com/fcm/send/fL4MGn77FGc:APA91bE9RjT5iS_lfuBIm7PeOS2789EzyWGbUrh-viIAgsGbJIG-Rc65ipPt8hFS6aLwiyvyfXsSIVTZTuISxPUo3kcaklfv_WYpZ4g1g8jY6wChNoHkRmDpGN7qFgI2SkrV2SxYlL-r',
+      'https://fcm.googleapis.com/fcm/send/ekhJ4l8bTqw:APA91bGyU0XqT5uWpyGzpx9TDtGc0m-CTPpjnnOVnl_ybIOlue7LPYlHoRyWZ4JgySwceHjmvDprQMW9vehEZn5ifluMA0Bq2FA5qfYceC3vv5YivFFtA2debLNbpfiLEN73WyoVJfgG',
     expirationTime: null,
     keys: {
       p256dh:
-        'BJSK63fSr4N3Vrx2DPFmRrGLglmDOZBFy5AwUDINlEFMQYHjDS2YjZbIYTuOGQVp4ZbzJKki6cCYcKsMHSBF9-Y',
-      auth: 'lzqdvQzre8BPRpJTvFJZng',
+        'BGPknDTtnF3sW5XPDzZl9DD2YqFY0WsyqZJ2Pxrzq8x1HY-5aF2aRiCz_QKDY2nj-ZFtqdBwRsV9yoPRg_015Vo',
+      auth: 'ynfeyAwBSXODSCaeRNQZiw',
     },
   },
   edge: {