Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize download JSON link #504

Open
NailKhalimov opened this issue Jun 5, 2020 · 3 comments
Open

Customize download JSON link #504

NailKhalimov opened this issue Jun 5, 2020 · 3 comments

Comments

@NailKhalimov
Copy link

Hello guys!

Do blockcerts-verifier have an opportunity to customize link for downloading?
I will be appreciative for this feature in close future🙏

@lemoustachiste
Copy link
Member

Hi @NailKhalimov,

Could you give a concrete example of what you would like to do?
At this moment this is the property being used: https://github.com/blockchain-certificates/blockcerts-verifier/blob/master/src/selectors/certificate.ts#L85 (to which we append a url parameter which can be ignored by your server). Is that something you could work with?

@NailKhalimov
Copy link
Author

NailKhalimov commented Jun 9, 2020

Hello @lemoustachiste,

Thanks for reply.
Sure, in general we have opportunity for downloading record. I mean now support only ?format=json without customize. But it would be good if developer can put custom link🙂
https://github.com/blockchain-certificates/blockcerts-verifier/blob/master/src/constants/downloadFlag.js

@lemoustachiste
Copy link
Member

Sorry I think I missed your answer.
it could be done quite easily I think. Would you want to work on a PR? Ideally I think we would constraint the property to remain format, but the value could be set or default to json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants