You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description:
I have deployed ERC-20 contract on the Polygon testnet (Mumbai)
While testing different commands, i have noticed that calling:
polygonetl filter_items -i contracts.csv -p "item['is_erc20'] or item['is_erc721']" | polygonetl extract_field -f address -o token_addresses.txt
return contract as token_address even if is_erc20 and is_erc721 items are FALSE
Check contracts.csv file and for contract (addr = 0x1a1586c38e38a094e42223a31896c40598516d05) is_erc20 and is_erc721 fields are FALSE. But filter_tems method detect that they are token_addresses and returns address in token_addresses.txt
Proposed solution
predicate(item) return string, so this condition will always be true.
Either change method to return bool or compare to string (if predicate(item)=="True":)
The text was updated successfully, but these errors were encountered:
Description:
I have deployed ERC-20 contract on the Polygon testnet (Mumbai)
While testing different commands, i have noticed that calling:
polygonetl filter_items -i contracts.csv -p "item['is_erc20'] or item['is_erc721']" | polygonetl extract_field -f address -o token_addresses.txt
return contract as token_address even if is_erc20 and is_erc721 items are FALSE
Enviroment:
PolygonEtl version: polygonetl, version 0.1.8
Network: Polygon Mumbai testnet
JSON-RPC: http://matic-mumbai.chainstacklabs.com/
Chain id: 80001
Transaction hash: 0x826a27ebe789e91bb06489dccf5e7382b6109f9eadccff696b32fcd64f1a0a32
Steps to reproduce:
Check contracts.csv file and for contract (addr = 0x1a1586c38e38a094e42223a31896c40598516d05) is_erc20 and is_erc721 fields are FALSE. But filter_tems method detect that they are token_addresses and returns address in token_addresses.txt
Proposed solution
predicate(item) return string, so this condition will always be true.
Either change method to return bool or compare to string (if predicate(item)=="True":)
The text was updated successfully, but these errors were encountered: